Skip to content

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Oct 15, 2024

Adds a "volumes" property to the compute terraform variable which defines optional OpenTofu-controlled volumes attached to compute nodes. Useful for simulating additional disks present in baremetal instances using virtualized instances.

Note that:

  • Unlike the default home and state volumes` attached to the control node, compute volumes defined this way are not automatically formatted or mounted.
  • Volumes are attached after instance creation and the path under /dev/{v,s}d* is likely to change across reboots. Use e.g. /dev/disk/by-path/ for mounts etc.

@sjpb sjpb changed the title allow creating tofu-controlled compute volumes Allow creating tofu-controlled compute volumes Oct 15, 2024
@wtripp180901
Copy link
Contributor

Warning: updating images for compute nodes currently forces them to be destroyed and replaced as the uuid of their block devices changes, even if no volumes are defined for them

@sjpb sjpb force-pushed the feat/compute-vols branch from 953b768 to b2126e0 Compare January 7, 2025 10:31
@sjpb
Copy link
Collaborator Author

sjpb commented Jan 7, 2025

Warning: updating images for compute nodes currently forces them to be destroyed and replaced as the uuid of their block devices changes, even if no volumes are defined for them

This is fixed in final PR, by attaching volumes to compute nodes rather than defining them as part of the block device configuration for the node.

@sjpb sjpb marked this pull request as ready for review January 7, 2025 10:42
@sjpb sjpb requested a review from a team as a code owner January 7, 2025 10:42
@sjpb
Copy link
Collaborator Author

sjpb commented Jan 9, 2025

Replaced by #528

@sjpb sjpb closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants